New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rbd: add support for mirror image promotion/demotion/resync #8138
Conversation
@jdurgin I quickly threw these CLI commands together since I need to reference them in the admin documentation. |
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
return -EBUSY; | ||
} | ||
|
||
r = Journal<>::allocate_tag(ictx, Journal<>::LOCAL_MIRROR_UUID); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess we might want an interlock with rbd-mirror here so that it doesn't have any i/o in flight to the local image after it's promoted, so it can be used after promotion immediately
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah -- might be good for me to throw a TODO here
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
When a client is disconnected from the journal, entries can be pruned regardless of the affected client's commit position. Signed-off-by: Jason Dillaman <dillaman@redhat.com>
A secondary image will store its resync request to the primary image's journal. When the local rbd mirror process detects the flag being set, it can initiate a resync from the remote. Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
rbd: add support for mirror image promotion/demotion/resync Reviewed-by: Josh Durgin <jdurgin@redhat.com>
No description provided.