rbd-mirror: fix long termination due to 30sec wait in Mirror::run loop #8185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| mirror->run(); | ||
| while (!stopping.read()) { | ||
| struct timeval sleep_time{1, 0}; | ||
| ::select(0, NULL, NULL, NULL, &sleep_time); |
There was a problem hiding this comment.
rather use c++11's sleep_for or a plain sleep() (no need for hi-res here)
There was a problem hiding this comment.
I used select() here because I knew it would interrupt if signal were received (so no delay before shutdown). I will check sleep()/sleep_for.
Signed-off-by: Mykola Golub <mgolub@mirantis.com>
trociny
force-pushed
the
wip-rbd-mirror-faster-exit
branch
from
a13cf7b
to
bbac766
Compare
|
Ah, actually, I should have looked how SignalHandler framework work first! I thought register_async_signal_handler() is just a wrapper for sigaction(), but actually we have a thread for handling signals. So it looks it is safe to just signal the condition in Mirror::handle_signal(). I have rebased the PR. |
|
lgtm |
dillaman
pushed a commit
that referenced
this pull request
Mar 19, 2016
rbd-mirror: fix long termination due to 30sec wait in main loop Reviewed-by: Jason Dillaman <dillaman@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mykola Golub mgolub@mirantis.com