Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: rgw_region_root_pool option should be in [global] #8271

Merged
merged 1 commit into from Mar 23, 2016

Conversation

vumrao
Copy link
Contributor

@vumrao vumrao commented Mar 23, 2016

doc: rgw_region_root_pool option should be in [global]
Fixes: #15244
Signed-off-by: Vikhyat Umrao vumrao@redhat.com

@theanalyst
Copy link
Member

I think this should only make it in infernalis and older.. iirc in jewel, rgw_region_root_pool should become rgw_zonegroup_root_pool, also can you check whether this behaviour is the same in the current master as well?

@theanalyst
Copy link
Member

@vumrao also see commit 796e470

@vumrao
Copy link
Contributor Author

vumrao commented Mar 23, 2016

@theanalyst Thanks for your inputs.

  • Yes in Jewel regions would be zonegroup.
  • I think then it would be better to send this change to hammer and infernalis and modify this one for rgw_zonegroup_root_pool.
  • radosgw-admin zonegroups list
    read_default_id : -2
    {
    "default_info": "",
    "zonegroups": [
    "default"
    ]
    }
  • I checked in latest Jewel and it is same it should be in global.

$ ceph osd pool rename .rgw.root .IN.rgw.root
pool '.rgw.root' renamed to '.IN.rgw.root'

$ radosgw-admin zonegroups list
failed to list zonegroups: (2) No such file or directory

  • Added in global section of ceph.conf
    $ cat /etc/ceph/ceph.conf
    rgw_zonegroup_root_pool = .IN.rgw.root

$ radosgw-admin zonegroups list
read_default_id : -2
{
"default_info": "",
"zonegroups": [
"default"
]
}

  • Works perfectly fine.
  • But if I am moving it to [client.rgw.] section it is failing.
  • Only name has changed but the location is same [global] section.
  • I will rebase with * new* name : rgw_zonegroup_root_pool for master and will send new patches for hammer and infernalis.

@vumrao
Copy link
Contributor Author

vumrao commented Mar 23, 2016

I think it would be good to make it like this - New in version - Jewel as given in below link for rgw region root pool option in version 0.67:
http://docs.ceph.com/docs/master/radosgw/config-ref/#pools

@theanalyst
Copy link
Member

I think it would be good to make it like this - New in version - Jewel as given in below link for rgw region root pool option in version 0.67:
http://docs.ceph.com/docs/master/radosgw/config-ref/#pools

Yes, makes sense

     add new option rgw_zonegroup_root_pool from Jewel.

Fixes: ceph#15244

Signed-off-by: Vikhyat Umrao <vumrao@redhat.com>
@vumrao
Copy link
Contributor Author

vumrao commented Mar 23, 2016

@theanalyst thanks

@theanalyst
Copy link
Member

LGTM

@yehudasa yehudasa merged commit 1b12901 into ceph:master Mar 23, 2016
@vumrao
Copy link
Contributor Author

vumrao commented Mar 24, 2016

@yehudasa thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants