hammer: rgw: radosgw server abort when user passed bad parameters to set quota #8313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: ceph#14190 when user passes bad parameter(e.g. pass "null" to bool parameter), the ceph_json.cc::decode_json_obj() will raise a exception with type of JSONDecoder::err(). If we do not catch this exception, the radosgw server will abort. $ curl -X PUT http://ceph1:9090/admin/metadata?user&format=json -d 'data = { "mtime": "null"}' terminate called after throwing an instance of 'JSONDecoder::err' *** Caught signal (Aborted) ** in thread 7ff982f55700 ceph version 10.0.1-787-gc485d29 (c485d29) 1: (ceph::BackTrace::BackTrace(int)+0x2d) [0x7ffa814db8c5] 2: (()+0x8fbfb7) [0x7ffa814dafb7] 3: (()+0xf100) [0x7ffa758a6100] 4: (gsignal()+0x37) [0x7ffa748e05f7] 5: (abort()+0x148) [0x7ffa748e1ce8] 6: (__gnu_cxx::__verbose_terminate_handler()+0x165) [0x7ffa751e49b5] 7: (()+0x5e926) [0x7ffa751e2926] 8: (()+0x5e953) [0x7ffa751e2953] 9: (()+0x5eb73) [0x7ffa751e2b73] 10: (bool JSONDecoder::decode_json<long>(char const*, long&, JSONObj*, bool)+0x28c) [0x7ffa8135920a] 11: (RGWMetadataManager::put(std::string&, ceph::buffer::list&, RGWMetadataHandler::sync_type_t, obj_version*)+0x173) [0x7ffa81468029] 12: (RGWOp_Metadata_Put::execute()+0x172) [0x7ffa81308dcc] 13: (()+0x7532d2) [0x7ffa813322d2] 14: (RGWFCGXProcess::handle_request(RGWRequest*)+0x90) [0x7ffa813328a4] Reported-by: Coffee Chou <coffee.zyr@gmail.com> Signed-off-by: Dunrong Huang <riegamaths@gmail.com> (cherry picked from commit 8350323) Conflicts: src/rgw/rgw_user.cc hammer version uses RGWUserInfo instead of RGWUserCompleteInfo
when user passes bad parameter(e.g. pass "null" to bool parameter), the ceph_json.cc::decode_json_obj() will raise a exception with type of JSONDecoder::err(). If we do not catch this exception, the radosgw server will abort. Fixes: ceph#14191 $ curl -X PUT http://ceph1:9090/admin/user?quota&uid=test5"a-type=user -d '{"enabled": "null"}' 0> 2015-12-28 11:25:20.864091 7f0d46fb5700 -1 *** Caught signal (Aborted) ** in thread 7f0d46fb5700 ceph version 10.0.1-787-gc485d29 (c485d29) 1: (ceph::BackTrace::BackTrace(int)+0x2d) [0x7f0e13ef88c5] 2: (()+0x8fbfb7) [0x7f0e13ef7fb7] 3: (()+0xf100) [0x7f0e082c3100] 4: (gsignal()+0x37) [0x7f0e072fd5f7] 5: (abort()+0x148) [0x7f0e072fece8] 6: (__gnu_cxx::__verbose_terminate_handler()+0x165) [0x7f0e07c019b5] 7: (()+0x5e926) [0x7f0e07bff926] 8: (()+0x5e953) [0x7f0e07bff953] 9: (()+0x5eb73) [0x7f0e07bffb73] 10: (bool JSONDecoder::decode_json<bool>(char const*, bool&, JSONObj*, bool)+0x288) [0x7f0e13d74c2c] 11: (RGWQuotaInfo::decode_json(JSONObj*)+0x6c) [0x7f0e13d71128] 12: (void decode_json_obj<RGWQuotaInfo>(RGWQuotaInfo&, JSONObj*)+0x23) [0x7f0e13d21f16] 13: (int rgw_rest_get_json_input<RGWQuotaInfo>(CephContext*, req_state*, RGWQuotaInfo&, int, bool*)+0x11e) [0x7f0e13d21e48] 14: (RGWOp_Quota_Set::execute()+0x8c9) [0x7f0e13d1ed6d] 15: (()+0x7532d2) [0x7f0e13d4f2d2 Reported-by: Coffee Chou <coffee.zyr@gmail.com> Signed-off-by: Dunrong Huang <riegamaths@gmail.com> (cherry picked from commit 59f9058) Conflicts: src/rgw/rgw_rest.h hammer version lacks rgw_rest_get_json_input_keep_data() template
ghost
pushed a commit
that referenced
this pull request
Apr 5, 2016
… passed bad parameters to set quota Reviewed-by: Loic Dachary <ldachary@redhat.com>
smithfarm
added a commit
that referenced
this pull request
Jun 1, 2016
… passed bad parameters to set quota Reviewed-by: Nathan Cutler <ncutler@suse.com>
|
@smithfarm any update on this? (pending_backport in tracker 14191) |
|
@mattbenjamin It is included in the current integration testing round. Status is always available at http://tracker.ceph.com/issues/15895 |
|
Any idea what could be causing this crash? http://tracker.ceph.com/issues/16323 |
smithfarm
added a commit
that referenced
this pull request
Jun 27, 2016
… passed bad parameters to set quota Reviewed-by: Nathan Cutler <ncutler@suse.com>
smithfarm
added a commit
that referenced
this pull request
Jul 18, 2016
… passed bad parameters to set quota Reviewed-by: Nathan Cutler <ncutler@suse.com>
smithfarm
added a commit
that referenced
this pull request
Jul 24, 2016
… passed bad parameters to set quota Reviewed-by: Nathan Cutler <ncutler@suse.com>
|
@oritwas This PR passed an rgw suite with some valgrind-related failures that appear harmless - see http://tracker.ceph.com/issues/15895#note-19 Do you think this PR is ready to merge? |
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tracker.ceph.com/issues/15257