Makefile-env.am: set a default for CEPH_BUILD_VIRTUALENV (part 2) #8320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new default must be taken into account by make check scripts otherwise they fail. Followup of 5b3da26. Signed-off-by: Loic Dachary <loic@dachary.org>
|
pushed in gitbuilders under the branch wip-virtualenv-jewel |
|
failed the centos7 builds... |
|
The failure is unrelated RPM build errors: Installed (but unpackaged) file(s) found: /etc/cron.hourly/subman.pyc /etc/cron.hourly/subman.pyo I'll fix it in another pull request ( #8334 ) |
ghost
mentioned this pull request
|
I guess this fixes "running the make check scripts outside of make check" (the addition of the default) as well as "running make check inside make check" (adding the extra slash)? Either way, this all looks right to me, and sorry I didn't see it as assigned to me for five days. Pings always welcome if it looks like I'm ignoring something |
|
@dmick it was a long week-end, I would have pinged you about it today ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new default must be taken into account by make check scripts
otherwise they fail.
Signed-off-by: Loic Dachary loic@dachary.org