cmake: Build cython modules and change paths to bin/, lib/ #8351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ali Maredia <amaredia@redhat.com>
|
don't we need to fix stop.sh? |
|
@oritwas you're right: I forget about stop.sh because I just use the killall path of it |
added 2 commits
March 29, 2016 13:42
Cribbed this from Ali's wip-cmake-make-check branch. Signed-off-by: John Spray <john.spray@redhat.com>
Signed-off-by: John Spray <john.spray@redhat.com>
|
Updated for stop.sh |
|
thanks for pulling these patches out! i was able to build cleanly, and vstart/stop worked from the cmake build directory as expected 👍 |
|
The ceph.in path changes broke the automake python path in a dev setup. fixed in #8360 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is derived from #7908 and #7912
Ali's original change included changing build paths for other binaries, so this branch includes the changes elsewhere to accomodate that. There is also a change in ceph-qa-suite for the paths ceph/ceph-qa-suite#916