Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: fix compiling warnings #8366

Merged
merged 3 commits into from Apr 3, 2016
Merged

build: fix compiling warnings #8366

merged 3 commits into from Apr 3, 2016

Commits on Mar 31, 2016

  1. test/system: fix a -Wsign-compare warning in compiling. 

    test/system/st_rados_create_pool.cc: In function ‘std::__cxx11::string get_temp_pool_name(const char*)’:
test/system/st_rados_create_pool.cc:128:9: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
   assert(ret < sizeof(poolname));
         ^

Signed-off-by: Dongsheng Yang <dongsheng.yang@easystack.cn>
    @yangdongsheng
    yangdongsheng committed Mar 31, 2016
    Configuration menu
    Copy the full SHA
    565ab25 View commit details
    Browse the repository at this point in the history

  2. test/objectstore: fix a -Wsign-compare warning in compiling. 

    In file included from test/objectstore/store_test.cc:33:0:
../src/gmock/gtest/include/gtest/gtest.h: In instantiation of ‘testing::AssertionResult testing::internal::CmpHelperEQ(const char*, const char*, const T1&, const T2&) [with T1 = unsigned int; T2 = int]’:
../src/gmock/gtest/include/gtest/gtest.h:1524:23:   required from ‘static testing::AssertionResult testing::internal::EqHelper<true>::Compare(const char*, const char*, const T1&, const T2&, typename testing::internal::EnableIf<(! testing::internal::is_pointer<T2>::value)>::type*) [with T1 = unsigned int; T2 = int; typename testing::internal::EnableIf<(! testing::internal::is_pointer<T2>::value)>::type = void]’
test/objectstore/store_test.cc:1088:285:   required from here
../src/gmock/gtest/include/gtest/gtest.h:1448:16: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
   if (expected == actual) {
                ^

Signed-off-by: Dongsheng Yang <dongsheng.yang@easystack.cn>
    @yangdongsheng
    yangdongsheng committed Mar 31, 2016
    Configuration menu
    Copy the full SHA
    c97ce4f View commit details
    Browse the repository at this point in the history

  3. os/filestore: fix a -Wunused-label warning in compiling. 

    os/filestore/FileStore.cc: In member function ‘int FileStore::_zero(const coll_t&, const ghobject_t&, uint64_t, size_t)’:
os/filestore/FileStore.cc:3328:2: warning: label ‘out’ defined but not used [-Wunused-label]
  out:
  ^

Signed-off-by: Dongsheng Yang <dongsheng.yang@easystack.cn>
    @yangdongsheng
    yangdongsheng committed Mar 31, 2016
    Configuration menu
    Copy the full SHA
    f6be50d View commit details
    Browse the repository at this point in the history