Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ceph-detect-init/run-tox.sh: FreeBSD: No init detect #8373

Merged
1 commit merged into from Mar 31, 2016

Conversation

wjwithagen
Copy link
Contributor

  • Freebsd has /etc/rc.d with scripts to start daemons at boottime.
    Test for that are currently not integrated with Ceph tests

Signed-off-by: Willem Jan Withagen wjw@digiware.nl

@ghost ghost self-assigned this Mar 30, 2016
@ghost
Copy link

ghost commented Mar 30, 2016

Could you instead

if test "`uname`"  = FreeBSD ; then
 echo warning
 exit 0
fi

it's a detail but makes it clearer that it's a FreeBSD only thing.

@wjwithagen
Copy link
Contributor Author

On 30-3-2016 13:37, Loic Dachary wrote:

Could you instead

if test "uname" = FreeBSD ; then
echo warning
exit 0
fi

it's a detail but makes it clearer that it's a FreeBSD only thing.

Sure, I liked the case-construct because it would be easier to extend to
other OSes, since I also ran into AIX, sun, Darwin, ... defines.
And when they want to run the tests it is easier to rinse-repeat and
extend. But for just FreeBSD it is fine.

@wjwithagen wjwithagen force-pushed the patch-4 branch 2 times, most recently from 4993c19 to 8dc2c21 Compare March 30, 2016 13:15
@ghost
Copy link

ghost commented Mar 30, 2016

Reviewed-by: Loic Dachary <ldachary@redhat.com>

 - Freebsd has /etc/rc.d with scripts to start daemons at boottime.
   Test for that are currently not integrated with Ceph tests

Signed-off-by: Willem Jan Withagen <wjw@digiware.nl>
@ghost ghost merged commit e550552 into ceph:master Mar 31, 2016
@wjwithagen wjwithagen deleted the patch-4 branch April 28, 2017 09:23
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant