librbd: disable image mirroring when image is removed #8375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1943,6 +1943,19 @@ int mirror_image_disable_internal(ImageCtx *ictx, bool force) { | |||
| return r; | |||
| } | |||
|
|
|||
| if (!old_format) { | |||
| r = mirror_image_disable_internal(ictx, true); | |||
There was a problem hiding this comment.
We probably want false for the force flag. If the image isn't primary, it is probably being replicated. If a delete is truly desired, promote it first or delete the primary image and let the deletion propagate over to the peer cluster.
dillaman
changed the title
|
Fixed commit |
| lderr(cct) << "cannot disable mirroring: " << cpp_strerror(r) << dendl; | ||
| return r; | ||
| } | ||
| else if (r == -ENOENT) { |
There was a problem hiding this comment.
nit: else should be on the same line as } and {
…is removed Signed-off-by: Ricardo Dias <rdias@suse.com> Fixes: ceph#15265
|
@jdurgin fixed :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #15265
Ticket url: http://tracker.ceph.com/issues/15265