mds: Add cmapv to ESessions default constructor initializer list #8403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dx9
force-pushed
the
wip-ceph-dencoder-esessions-fix
branch
from
8f2985f
to
0842620
Compare
dx9
changed the title
| @@ -28,7 +28,7 @@ class ESessions : public LogEvent { | |||
| map<client_t,entity_inst_t> client_map; | |||
| bool old_style_encode; | |||
|
|
|||
| ESessions() : LogEvent(EVENT_SESSIONS), old_style_encode(false) { } | |||
| ESessions() : LogEvent(EVENT_SESSIONS), cmapv(), old_style_encode(false) { } | |||
Fixes uninitialized values in cmapv which cause ceph-dencoder tests to fail. Signed-off-by: John Coyle <dx9err@gmail.com>
dx9
force-pushed
the
wip-ceph-dencoder-esessions-fix
branch
from
0842620
to
1a6c686
Compare
gregsfortytwo
added a commit
that referenced
this pull request
Apr 5, 2016
…9/ceph into greg-fs-testing #8403
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2 EOpen
1 EResetJournal
1 ESession
1 ESessions
/tmp/typ-0xkIaUoD0 /tmp/typ-BGoHeqaPh differ: char 31, line 2
**** ESessions test 1 dump_json check failed ****
./ceph-dencoder type ESessions select_test 1 dump_json > /tmp/typ-0xkIaUoD0
./ceph-dencoder type ESessions select_test 1 encode decode dump_json > /tmp/typ-BGoHeqaPh
diff /tmp/typ-0xkIaUoD0 /tmp/typ-BGoHeqaPh
/tmp/typ-0xkIaUoD0 /tmp/typ-tiU63rZX2 differ: char 30, line 2
**** ESessions test 1 copy dump_json check failed ****
./ceph-dencoder type ESessions select_test 1 dump_json > /tmp/typ-0xkIaUoD0
./ceph-dencoder type ESessions select_test 1 copy dump_json > /tmp/typ-BGoHeqaPh
diff /tmp/typ-0xkIaUoD0 /tmp/typ-BGoHeqaPh
/tmp/typ-0xkIaUoD0 /tmp/typ-UQHZ1V5Cl differ: char 31, line 2
**** ESessions test 1 copy_ctor dump_json check failed ****
./ceph-dencoder type ESessions select_test 1 dump_json > /tmp/typ-0xkIaUoD0
./ceph-dencoder type ESessions select_test 1 copy_ctor dump_json > /tmp/typ-BGoHeqaPh
diff /tmp/typ-0xkIaUoD0 /tmp/typ-BGoHeqaPh
/tmp/typ-0xkIaUoD0 /tmp/typ-BGoHeqaPh differ: char 11, line 1
**** ESessions test 1 binary reencode check failed ****
./ceph-dencoder type ESessions select_test 1 encode export /tmp/typ-0xkIaUoD0
./ceph-dencoder type ESessions select_test 1 encode decode encode export /tmp/typ-BGoHeqaPh
cmp /tmp/typ-0xkIaUoD0 /tmp/typ-BGoHeqaPh
1 ESlaveUpdate
1 ESubtreeMap
1 ETableClient
1 ETableServer
1 EUpdate
rkb:~/ceph/src$ cat /tmp/typ-n8fovLxy5
{
"client map version": 138185855205184,
"client map": []
}
rkb:~/ceph/src$ cat /tmp/typ-PPFrpu8uR
{
"client map version": 124927316901915,
"client map": []
}