Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debian/rules: put init-ceph in /etc/init.d/ceph, not ceph-base #8406

Merged
merged 1 commit into from Apr 1, 2016

Conversation

dmick
Copy link
Member

@dmick dmick commented Apr 1, 2016

When the package name changed from ceph to ceph-base, dh_installinit
started installing the init script into /etc/init.d/ceph-base. Fix
this by using --name ceph with dh_installinit, which requires

  1. naming the .init file ceph-base.ceph.init, and
  2. calling dh_installinit separately for each package

http://tracker.ceph.com/issues/15329

Signed-off-by: Dan Mick dan.mick@redhat.com

@dmick
Copy link
Member Author

dmick commented Apr 1, 2016

Tested with build-debs.sh, verifying that ceph-base.deb now contains /etc/init.d/ceph

@tchaikov tchaikov added this to the jewel milestone Apr 1, 2016
@tchaikov
Copy link
Contributor

tchaikov commented Apr 1, 2016

lgtm.

Dan, could you put Fixes: http://tracker.ceph.com/issues/15329 right before your Signed-off-by line, see https://github.com/ceph/ceph/blob/master/SubmittingPatches.rst#preparing-and-sending-patches. we start using this notation couple days ago.

@dmick
Copy link
Member Author

dmick commented Apr 1, 2016

I can, although the URL is already there, and I know tracker is going to pay no attention to it anyway...but I will fix it up

When the package name changed from ceph to ceph-base, dh_installinit
started installing the init script into /etc/init.d/ceph-base.  Fix
this by using --name ceph with dh_installinit, which requires
1) naming the .init file ceph-base.ceph.init, and
2) calling dh_installinit separately for each package

Fixes: http://tracker.ceph.com/issues/15329
Signed-off-by: Dan Mick <dan.mick@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants