Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mds: fix file_layout_t legacy encoding snafu #8455

Merged
merged 2 commits into from Apr 6, 2016

Conversation

liewegas
Copy link
Member

@liewegas liewegas commented Apr 5, 2016

  • dump pool_id properly
  • data pool 0 is a valid legacy thing, and exists on old clusters, where
    0=data, 1=metadata, 2=rbd. Remove the blind 0 <-> -1 mapping.
  • ensure that a zeroed ceph_file_layout still matches file_layout_t

If you data pool was pool 0, this was transforming
that to -1 unconditionally, which broke upgrades.  We
only want do that for a fully zeroed ceph_file_layout,
so that it still maps to a file_layout_t.  If any fields
are set, though, we trust the fl_pgpool to be a valid
pool.

Signed-off-by: Sage Weil <sage@redhat.com>
Signed-off-by: Sage Weil <sage@redhat.com>
@liewegas liewegas added bug-fix cephfs Ceph File System labels Apr 5, 2016
@liewegas liewegas added this to the jewel milestone Apr 5, 2016
@jcsp jcsp merged commit 1238bd8 into ceph:master Apr 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants