rbd-mirror: workaround for intermingled lockdep singletons #8476
Conversation
|
@dillaman lgtm --- already tested and the assertion failure is no more. |
|
@rjfd Yeah -- we run into lots of issues due to dual linkage of libcommon/libosdc/etc in librados and librbd/other apps. |
|
This reminds me we might want to use CINIT_FLAG_UNPRIVILEGED_DAEMON_DEFAULTS for common_preinit() to get logs and asok by default for the remote cluster too. |
|
@dillaman Good idea, but there is an issue with the patch: by some reason command line options are not applied. You can see this running rbd_mirror.sh with NOCLEANUP, and observe that asok and log files are not created in tmp directory but in run/cluster2/out directory (as specified in cluster2.conf). So far I have failed to understand why. |
| return r; | ||
| } | ||
|
|
||
| if (!m_args.empty()) { | ||
| r = m_remote->conf_parse_argv(m_args.size(), &m_args[0]); | ||
| // librados::Rados::conf_parse_argv | ||
| r = cct->_conf->parse_argv(args); |
There was a problem hiding this comment.
@dillaman s/args/m_args/ :-)
If librados constructs the CephContext, lockdep will be initialized in both the librados shared address space and also within the app address space. This breaks lockdep's functionality and results in a crash upon shutdown. Signed-off-by: Jason Dillaman <dillaman@redhat.com>
dillaman
force-pushed
the
wip-rbd-mirror-lockdep
branch
from
fb9aece
to
017d830
Compare
|
Updated and fixed -- thx. |
|
lgtm |
If librados constructs the CephContext, lockdep will be initialized
in both the librados shared address space and also within the app
address space. This breaks lockdep's functionality and results in
a crash upon shutdown.
Signed-off-by: Jason Dillaman dillaman@redhat.com