jewel: tools: ceph-disk: Accept bcache devices as data disks

[sabaini]

Fixes: http://tracker.ceph.com/issues/13278
Signed-off-by: Peter Sabaini peter@sabaini.at

[ErwanAliasr1]

Would be nice to get a topic like "ceph-disk: Accept bcache devices as data disks"

[sabaini]

Sure, like this?

[ErwanAliasr1]

Thanks

[tchaikov]

@sabaini ideally you might want to update the title of your commit message with the prefix suggested by @ErwanAliasr1 , using "git commit --amend" and "git push -f".

[tchaikov]

@dachary mind taking a look?

[ghost]

@sabaini this assumes that bcache devices always are partitions, right ?

[ghost]

Hey jenkins, test this please !

[sabaini]

@dachary Correct, the individual /dev/bcacheN devices are always partitions
FWIW, the bcache docs are a bit terse but describe this here: https://evilpiepirate.org/git/linux-bcache.git/tree/Documentation/bcache.txt

[smithfarm]

Do we know why this feature was merged to jewel when it is not present in master?

[sabaini]

This might just be a mistake on my part. I'd be happy to do a PR against master

[smithfarm]

@sabaini If it's really missing in master (I haven't checked), that means it dies when jewel goes EOL. So a PR against master might be a good idea.

[hansbogert]

@smithfarm maybe it should be EOL, because since kernel 4.10, bcache devices can definitely have partitions.
I had to monkey patch /usr/lib/python2.7/dist-packages/ceph_disk/main.py on machines, to get expected behavior during deploy.

Expected behavior being: bcache devices being automatically mounted and activated by Ceph, without resorting to a manual fstab config, and a hardcoded ceph.conf which holds a mapping journals to data (bcache) disks.

/edit, already picked up at #16061

[smithfarm]

Sorry, I didn't realize this was merged in July 2016 (I was thinking 2017).