rgw: Ensure xmlns is consistent on S3 responses. #8526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At least one S3 client is overly strict about requiring the xmlns to be present in server responses. Let's be strict about what we send, and continue to be lax about what we receive. - Put correct XMLNS in a define instead of repeating it. - Correct XMLNS hostname: s/doc.s3.amazonaws.com/s3.amazonaws.com/ - Add XMLNS where it was missing: -- CORSConfiguration -- CopyObjectResult (see S3QL#190) -- ListMultipartUploadsResult S3QL bug ceph#190: https://bitbucket.org/nikratio/s3ql/issues/190/sq3l-should-not-rely-on-xmlns-declarations Signed-off-by: Robin H. Johnson <robin.johnson@dreamhost.com>
|
+1 for this |
|
Jenkins: retest this please |
|
+1 |
|
@liewegas merge for Jewel? |
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At least one S3 client is overly strict about requiring the xmlns to be present
in server responses. Let's be strict about what we send, and continue to be lax
about what we receive.
-- CORSConfiguration
-- CopyObjectResult (see S3QL#190)
-- ListMultipartUploadsResult
S3QL bug #190: https://bitbucket.org/nikratio/s3ql/issues/190/sq3l-should-not-rely-on-xmlns-declarations
Signed-off-by: Robin H. Johnson robin.johnson@dreamhost.com