os/filestore: fix return type mismatch for lfn parse #8545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiexingguo
force-pushed
the
xxg-wip-lfn
branch
3 times, most recently
from
bca1777
to
142610a
Compare
According to ceph@755c685, we shall return a int value instead of bool now. So if we fail to parse an object, we shall reset "false" into "-EINVAL" instead, as "false" is always translated into 0, which is supposed to indicate a success. Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
|
lgtm |
|
@tchaikov Thanks for the quick review, and merge:) |
|
lgtm as well |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to 755c685,
we shall return a int value instead of bool now.
So if we fail to parse an object, we shall reset "false" into "-EINVAL" instead,
as "false" is always translated into 0, which is supposed to indicate a success.
Signed-off-by: xie xingguo xie.xingguo@zte.com.cn