Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

msg: mark daemons down on RST + ECONNREFUSED #8558

Merged
merged 6 commits into from
Sep 17, 2016
Merged

msg: mark daemons down on RST + ECONNREFUSED #8558

merged 6 commits into from
Sep 17, 2016

Commits on Sep 13, 2016

  1. msg/simple: add ms_handle_refused callback 

    Added new callback (ms_handle_refused) to dispatchers. It is called
once connection attempt fails with ECONNREFUSED.
Also added dummy ms_handle_refused handlers across codebase.

Signed-off-by: Piotr Dałek <git@predictor.org.pl>
    @branch-predictor
    branch-predictor committed Sep 13, 2016
    Configuration menu
    Copy the full SHA
    d58d7d3 View commit details
    Browse the repository at this point in the history

  2. OSD: Implement ms_handle_refused 

    Added implementation of ms_handle_refused in OSD code, so it sends
MOSDFailure message in case the peer connection fails with ECONNREFUSED
*and* it is known to be up and new option "osd fast fail on connection
refused" which enables or disables new behavior.

Signed-off-by: Piotr Dałek <git@predictor.org.pl>
    @branch-predictor
    branch-predictor committed Sep 13, 2016
    Configuration menu
    Copy the full SHA
    7507452 View commit details
    Browse the repository at this point in the history

  3. messages/MOSDFailure.h: distinguish between timeout and immediate fai… 

    …lure

Change "is_failed" field to "flags" and use it to distinguish between timeout
and immediate, known OSD failure. Then use that in OSD and MON, and make sure
"min_reporters" don't affect known failures by actually going around failure
heuristic code.

Signed-off-by: Piotr Dałek <git@predictor.org.pl>
    @branch-predictor
    branch-predictor committed Sep 13, 2016
    Configuration menu
    Copy the full SHA
    fca6817 View commit details
    Browse the repository at this point in the history

  4. msg/async: implement ECONNREFUSED detection 

    This commit adds code that detects ECONNREFUSED and dispatches appropriate
event further in Async messenger.

Signed-off-by: Piotr Dałek <git@predictor.org.pl>
    @branch-predictor
    branch-predictor committed Sep 13, 2016
    Configuration menu
    Copy the full SHA
    5083742 View commit details
    Browse the repository at this point in the history

  5. test/osd: add test for fast mark down functionality 

    Test checks both async and simple messenger and also checks whether
disabling "osd fast fail on connection refused" option restores old
behavior.

Signed-off-by: Piotr Dałek <git@predictor.org.pl>
    @branch-predictor
    branch-predictor committed Sep 13, 2016
    Configuration menu
    Copy the full SHA
    3ed8169 View commit details
    Browse the repository at this point in the history

  6. osdc: remove MOSDFailure include 

    Doesn't seem to be necessary anymore.

Signed-off-by: Piotr Dałek <git@predictor.org.pl>
    @branch-predictor
    branch-predictor committed Sep 13, 2016
    Configuration menu
    Copy the full SHA
    675a8de View commit details
    Browse the repository at this point in the history