Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ceph_test_rados: make long name ~300 chars, (not ~800) #8600

Merged
merged 1 commit into from Apr 14, 2016
Merged

ceph_test_rados: make long name ~300 chars, (not ~800) #8600

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 1 addition & 4 deletions src/test/osd/TestRados.cc
View file
Open in desktop
Expand Up @@ -56,10 +56,7 @@ class WeightedTestGenerator : public TestOpGenerator
oid << m_op;
if (m_op % 2) {
// make it a long name
oid << " ";
for (unsigned i = 0; i < 300; ++i) {
oid << i;
}
oid << " " << string(300, 'o');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@liewegas i don't get it, we append 301 spaces to oid before. and we append a string of 301 spaces in this change. so nothing changed in this patch. it's but a refactor unlike claimed by the commit message?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, right!

}
cout << m_op << ": write initial oid " << oid.str() << std::endl;
context.oid_not_flushing.insert(oid.str());
Expand Down