Fixes for python omap method return values. #8603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Roland Mechler <rmechler@cisco.com>
|
lgtm, nice catch |
| @@ -2799,7 +2799,9 @@ returned %d, but should return zero on success." % (self.name, ret)) | |||
| int _flags = flags | |||
|
|
|||
| with nogil: | |||
| rados_write_op_operate(_write_op.write_op, self.io, _oid, &_mtime, _flags) | |||
| ret = rados_write_op_operate(_write_op.write_op, self.io, _oid, &_mtime, _flags) | |||
| if (ret != 0): | |||
There was a problem hiding this comment.
could also remove the parentheses here.
There was a problem hiding this comment.
I used parentheses because I copied the style from similar code elsewhere in the file. There seems to be a mix of styles (parentheses vs not) in the file. So, should I (a) leave this as is, (b) remove the parentheses only on the code I've added, or (c) make the style consistent (no parentheses) everywhere in the file?
There was a problem hiding this comment.
I'd suggest (b) for this pr. A separate pr removing parens from ifs everywhere in pybind would be great. It's just a historical accident that kept getting copied.
Signed-off-by: Roland Mechler <rmechler@cisco.com>
|
passed python2 and 3 tests locally |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Roland Mechler rmechler@cisco.com