jewel: common: global-init: fixup chown of the run directory along with log and asok files #8754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Karol Mroz <kmroz@suse.com> (cherry picked from commit aecab14)
Signed-off-by: Karol Mroz <kmroz@suse.com> (cherry picked from commit 860977b)
If init flags have changed between the time ceph context was instantiated and now, update them. This can happen, for example, if between manual global_pre_init() and global_init() calls, a daemon adds modifies it's init flags. Signed-off-by: Karol Mroz <kmroz@suse.com> (cherry picked from commit a0ad13d)
Signed-off-by: Karol Mroz <kmroz@suse.com> (cherry picked from commit 206585c)
Also performs log file chown() operations if permission drop has been deferred. Documents that admin socket chown() happen in the common init path. Signed-off-by: Karol Mroz <kmroz@suse.com> (cherry picked from commit 9d51379)
Signed-off-by: Karol Mroz <kmroz@suse.com> (cherry picked from commit 9c82d84)
Signed-off-by: Karol Mroz <kmroz@suse.com> (cherry picked from commit 088cc66)
fchown() returns success, but does not change asok file ownership. chown() does. Signed-off-by: Karol Mroz <kmroz@suse.com> (cherry picked from commit 3d051a5)
ghost
pushed a commit
that referenced
this pull request
May 10, 2016
…directory along with log and asok files Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
May 10, 2016
Reviewed-by: Loic Dachary <ldachary@redhat.com>
|
test this please |
1 similar comment
|
test this please |
ghost
pushed a commit
that referenced
this pull request
May 11, 2016
…directory along with log and asok files Reviewed-by: Loic Dachary <ldachary@redhat.com>
|
test this please |
|
test this please (bluefs mount crash) |
|
test this please (log is no longer available) |
|
This seems to be failing make check. |
|
@dachary / @athanatos - Another bluefs mount crash. Performing a local run of make check, unittest_bluefs succeeds. |
|
test this please (bluefs mount crash) |
|
@dachary / @athanatos: |
ghost
pushed a commit
that referenced
this pull request
Jun 16, 2016
…directory along with log and asok files Reviewed-by:
|
@liewegas does this backport look good to merge ? It passed the rados suite http://tracker.ceph.com/issues/16344#note-7 except for one failure which I believe is unrelated). |
ghost
mentioned this pull request
theanalyst
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tracker.ceph.com/issues/15608