pybind/ceph_argparse: handle non ascii unicode args #8943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tchaikov
force-pushed
the
wip-12287
branch
2 times, most recently
from
c5226d2
to
9cdb999
Compare
the failure is not relevant. |
|
tested at
the failures are caued by environmental problem, test suite issues [1], and teuthology issue[2] [1] ceph/ceph-qa-suite#1031 |
we raise UnicodeDecodeError at seeing non-ascii args if we fail to match it with any command signatures. instead, we should use a unicode string for representing the error in that case. please note, the exception is not printed at all in real-world. =) Fixes: http://tracker.ceph.com/issues/12287 Signed-off-by: Kefu Chai <kchai@redhat.com>
|
@dachary could you help review this PR? |
|
Yikes, tricky :-( Good job :-) Reviewed-by: Loic Dachary <ldachary@redhat.com> as soon as make check verifies it does pass the test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we raise UnicodeDecodeError at seeing non-ascii args if we fail to match
it with any command signatures. instead, we should use a unicode string
for representing the error in that case. please note, the exception is not
printed at all in real-world. =)
Fixes: http://tracker.ceph.com/issues/12287
Signed-off-by: Kefu Chai tchaikov@gmail.com