DNM: use pytest #902
Closed
DNM: use pytest #902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rebased |
added 2 commits
December 14, 2013 22:05
The standard logging module makes it easier to capture errors in a
meaningfull way and reduces the nosetest generated noise. For instance:
PASS: test/encoding/check-generated.sh
..............F....................................................
======================================================================
FAIL: test_ceph_argparse.TestOSD.test_blackist
----------------------------------------------------------------------
Traceback (most recent call last):
File "/usr/lib/python2.7/dist-packages/nose/case.py", line 197, in runTest
self.test(*self.arg)
File "/home/loic/software/ceph/ceph/src/test/pybind/test_ceph_argparse.py", line 837, in test_blackist
'1.2.3.4/nonce'])
File "/home/loic/software/ceph/ceph/src/test/pybind/test_ceph_argparse.py", line 46, in assert_valid_command
assert_not_in(result, [None, {}])
AssertionError: {} unexpectedly found in [None, {}]
-------------------- >> begin captured logging << --------------------
root: ERROR: Invalid command: 1.2.3.4/nonce: invalid entity, nonce nonce not integer > 0
--------------------- >> end captured logging << ---------------------
----------------------------------------------------------------------
Ran 128 tests in 19.425s
Although the logging format distinguishes between warning, errors etc
with standardized prefixes, the format is set to just the message so
that it does not interfere with the current way of constructing error
messages printed on stderr.
Add emacs mode line at the beginning to get syntax highlighting
Signed-off-by: Loic Dachary <loic@dachary.org>
Signed-off-by: Loic Dachary <loic@dachary.org>
|
pushed to ceph to check that gitbuilder succeeds |
|
pytest is not in precise |
ghost
closed this
liewegas
pushed a commit
that referenced
this pull request
Dec 14, 2016
rbd: add singleton to assert no rbdmap regression Reviewed-by: Josh Durgin <jdurgin@redhat.com>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Up for review but needs to wait until #651 is merged
ceph/autobuild-ceph#4 probably reaches the build machines by now