hammer: ceph-osd valgrind invalid reads/writes #9238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
test this please |
smithfarm
changed the title
|
test this please |
1 similar comment
|
test this please |
Otherwise, if it is reaped while we are waiting, it'll be a use-after-free. Fixes: http://tracker.ceph.com/issues/15870 Signed-off-by: Samuel Just <sjust@redhat.com> (cherry picked from commit b224912) Conflicts: src/msg/simple/Pipe.cc: nullptr changed to 0 because hammer is not compiled with -std=c++11
smithfarm
force-pushed
the
wip-15962-hammer
branch
from
b02986f
to
055427c
Compare
smithfarm
changed the title
smithfarm
added a commit
that referenced
this pull request
Jun 27, 2016
Reviewed-by: Nathan Cutler <ncutler@suse.com>
smithfarm
added a commit
that referenced
this pull request
Jul 18, 2016
Reviewed-by: Nathan Cutler <ncutler@suse.com>
smithfarm
added a commit
that referenced
this pull request
Jul 24, 2016
Reviewed-by: Nathan Cutler <ncutler@suse.com>
|
@athanatos This PR is in the latest round of hammer-backports integration tests, which passed a rados run (the only failures are a valgrind false positive that has since been fixed by ceph/teuthology#915 and http://tracker.ceph.com/issues/15139 which is an infrastructure issue with two of the tests) - for details, see: http://tracker.ceph.com/issues/15895#note-18 Do you think this PR is OK to merge? |
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tracker.ceph.com/issues/15962