osdc: standardize osdc code with std::atomic #9257
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you squash these into 1 commit so they both build? |
liewegas
changed the title
|
@liewegas sorry, have squashed, please review. |
| @@ -1144,16 +1145,16 @@ class Objecter : public md_config_obs_t, public Dispatcher { | |||
| using Dispatcher::cct; | |||
| std::multimap<string,string> crush_location; | |||
|
|
|||
| atomic_t initialized; | |||
| atomic_bool initialized; | |||
There was a problem hiding this comment.
similar to #9138 (comment), can we qualify these with std::?
…c_atomic_replacement. same work as ceph#9138 Signed-off-by: Xiaowei Chen <chen.xiaowei@h3c.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
standalize ceph code with std::atomic other than ceph::atomic
same work as #9138
Signed-off-by: Xiaowei Chen chen.xiaowei@h3c.com