osd: print log when osd want to kill self #9288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Haomai Wang <haomai@xsky.com>
|
we want to know the reason make decision to shutdown, rebind failed or too much failure retries |
| @@ -6926,18 +6926,21 @@ void OSD::_committed_osd_maps(epoch_t first, epoch_t last, MOSDMap *m) | |||
| if (r != 0) { | |||
| do_shutdown = true; // FIXME: do_restart? | |||
| network_error = true; | |||
| dout(0) << __func__ << " marked down: rebind failed" << dendl; | |||
There was a problem hiding this comment.
Maybe print the class of messager will be better?
There was a problem hiding this comment.
for qa, I think developers could know the messenger type from job describe. for user, it should definitely be one type defined in ceph.conf
There was a problem hiding this comment.
i think it's aways MOSDMap?
There was a problem hiding this comment.
yes, message type should always be MOSDMap
liewegas
changed the title
|
retest this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Haomai Wang haomai@xsky.com