Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rgw/rados: remove confused error printout #9351

Merged
merged 1 commit into from Jun 30, 2016

Conversation

Yan-waller
Copy link
Contributor

@Yan-waller Yan-waller commented May 26, 2016

Maybe we should not print or log this failed message when
the pool_iterate returns -ENOENT which means no objects but failed.

this message will be print on the screen in the hammer version.

Signed-off-by: Yan Jun yan.jun8@zte.com.cn

Maybe we should not print or log the failed message
when pool_iterate returns -ENOENT which means no objects but failed.

this message will print on the screen the hammer version.

Signed-off-by: Yan Jun <yan.jun8@zte.com.cn>
@xiexingguo
Copy link
Member

Then we might want to cast answer to 0 if pool_iterate returns -ENOENT, too.

@robbat2
Copy link
Contributor

robbat2 commented May 26, 2016

I'd maybe log ENOENT at a higher level. It's been useful to me in the past.

@oritwas oritwas added the rgw label May 27, 2016
@oritwas oritwas self-assigned this May 27, 2016
@xiexingguo
Copy link
Member

retest this please

@Yan-waller
Copy link
Contributor Author

Yan-waller commented May 31, 2016

I mean that we will get the following errors, while there are no bucket or user at all in the hammer version, and the message will be logged as an error in later version.

[root@yanun ceph]# radosgw-admin metadata list bucket
[
]
2016-06-01 00:18:30.779689 7f31d711b880 -1 failed to list objects pool_iterate returned r=-2
[root@yanun ceph]# 
[root@yanun ceph]# radosgw-admin metadata list user
ERROR: lists_keys_next(): (2) No such file or directory
2016-06-01 00:27:38.486869 7fecd1390880 -1 failed to list objects pool_iterate returned r=-2
[root@yanun ceph]#

@Yan-waller
Copy link
Contributor Author

retest this please

@Yan-waller
Copy link
Contributor Author

@oritwas PING

@oritwas oritwas merged commit 082a073 into ceph:master Jun 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants