rgw: need to 'open_object_section' before dump stats in 'RGWGetUsage_… #9495
Conversation
|
@weiqiaomiao this is a public api (albeit rgw extension). Need to bring this change to the mailing list, people might be using it as is now. |
|
@chenji-kael please take a look at this one |
|
@yehudasa @weiqiaomiao |
|
@yehudasa I send a email to the mailing list（the email titile is 'RGW:add description for GET usage admin api response entity 'stats entry''), and there is no one reponse it. I think there is no people using this api except chenji. |
|
@weiqiaomiao |
|
@weiqiaomiao @chenji-kael I suggest that we switch to the new api, but make it configurable so that current users can fall back to the old api. What do you think? |
weiqiaomiao
force-pushed
the
wqm-wip-rgw-getusage
branch
from
e713a38
to
6affb06
Compare
|
@yehudasa @chenji-kael It is a good suggestion to me and update the commit yet. |
| @@ -1433,6 +1433,8 @@ OPTION(rgw_swift_versioning_enabled, OPT_BOOL, false) // whether swift object ve | |||
|
|
|||
| OPTION(rgw_list_bucket_min_readahead, OPT_INT, 1000) // minimum number of entries to read from rados for bucket listing | |||
|
|
|||
| OPTION(rgw_getusage_dump_description, OPT_BOOL, true) // dump description of total stats for s3 GetUsage API | |||
There was a problem hiding this comment.
@weiqiaomiao let's rename it to rgw_rest_getusage_op_compat, and default it to false (switch the flag's meaning)
weiqiaomiao
force-pushed
the
wqm-wip-rgw-getusage
branch
from
6affb06
to
f2ca253
Compare
|
@yehudasa Thanks for your suggestion, and the commit has been updated. Would you take a look at it again? |
|
@weiqiaomiao this looks ok. Last thing we need is that since this affects compatibility, we need to note it in the relase notes. Please add a description of this change, the new configurable (to override), and the api change to ceph/PendingReleaseNotes. Thanks. |
weiqiaomiao
force-pushed
the
wqm-wip-rgw-getusage
branch
2 times, most recently
from
2da1e22
to
e25a6f0
Compare
|
@yehudasa I already add this change to ceph/PendingReleaseNote. Would you take a look at it again.Thanks. |
| @@ -17,6 +17,24 @@ | |||
| listed in 'osd class default list' requires a capability naming the class | |||
| (e.g. 'allow class foo'). | |||
|
|
|||
| * The 'rgw_rest_getusage_op_compat' config option allow you to dump the description of user stats | |||
There was a problem hiding this comment.
@weiqiaomiao also, no underscores needed when specifying the config option
weiqiaomiao
force-pushed
the
wqm-wip-rgw-getusage
branch
from
e25a6f0
to
db5d426
Compare
|
@theanalyst the commit has been updated according to your suggestion. would you take a look at it again. thanks! |
|
@weiqiaomiao please note the two comments on the last commit |
…ObjStore_S3::send_response()' function Signed-off-by: weiqiaomiao <wei.qiaomiao@zte.com.cn>
weiqiaomiao
force-pushed
the
wqm-wip-rgw-getusage
branch
from
db5d426
to
4aea4a6
Compare
|
@yehudasa Thank you for reminding me. The commit has been updated. |
|
Created and merged another PR due to conflict, see #11325 |
|
@weiqiaomiao also updated commit message, noted tracker issue |
…ObjStore_S3::send_response()' function
Signed-off-by: weiqiaomiao wei.qiaomiao@zte.com.cn