jewel: librbd: prevent error messages when journal externally disabled #9610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's possible that the object map or journaling features have been disabled while the lock was not owned. Fixes: http://tracker.ceph.com/issues/16114 Signed-off-by: Jason Dillaman <dillaman@redhat.com> (cherry picked from commit 03c54f5)
If a client is waiting for the lock, ensure it sees the latest version of the image features. Signed-off-by: Jason Dillaman <dillaman@redhat.com> (cherry picked from commit f601ea8)
We are looping all the extents of the OSDWrite in writex. The looping in map_write is not needed. And if there are same object in these extents,they will be mapped multiple times. Signed-off-by: Zhiqiang Wang <zhiqiang@xsky.com> (cherry picked from commit 322f105)
The BufferHead returned after map_write may include other dirty data to the left and/or right. The actual length of data been written is in the ObjectExtent. Signed-off-by: Zhiqiang Wang <zhiqiang@xsky.com> (cherry picked from commit ca6f168)
Looping the extents of OSDRead is done in _readx. The looping in map_read is not needed. Signed-off-by: Zhiqiang Wang <zhiqiang@xsky.com> (cherry picked from commit fae912c)
Avoid the possibility of an overwrite callback for regions that were never associated with a journal write. Signed-off-by: Jason Dillaman <dillaman@redhat.com> (cherry picked from commit c6060ad)
Signed-off-by: Jason Dillaman <dillaman@redhat.com> (cherry picked from commit 276fed6)
|
Tested SAT (failures expected/environment noise): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tracker.ceph.com/issues/16209