jewel: tests: improve rbd-mirror test case coverage #9631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| exit $? | ||
| if [ -n "${CEPH_REF}" ]; then | ||
| wget -O rbd_mirror_helpers.sh "https://git.ceph.com/?p=ceph.git;a=blob_plain;hb=$CEPH_REF;f=qa/workunits/rbd/rbd_mirror_helpers.sh" | ||
| . rbd_mirror_helpers.sh |
There was a problem hiding this comment.
@dillaman Sorry, overlooked this before merging to master, but unfortunately this does not work on theuthology:
qa-proxy.ceph.com/teuthology/trociny-2016-06-11_08:56:35-rbd-wip-mgolub-testing---basic-vps/252017/teuthology.log
2016-06-11T09:18:53.634 INFO:tasks.workunit.cluster1.client.mirror.vpm121.stderr:--2016-06-11 16:18:53-- https://git.ceph.com/?p=ceph.git;a=blob_plain;hb=769695ee2afa360fecce4a7192fcb7f2f2eb0b25;f=qa/workunits/rbd/rbd_mirror_helpers.sh
2016-06-11T09:18:53.640 INFO:tasks.workunit.cluster1.client.mirror.vpm121.stderr:Resolving git.ceph.com (git.ceph.com)... 8.43.84.132
2016-06-11T09:18:53.641 INFO:tasks.workunit.cluster1.client.mirror.vpm121.stderr:Connecting to git.ceph.com (git.ceph.com)|8.43.84.132|:443... connected.
2016-06-11T09:18:53.826 INFO:tasks.workunit.cluster1.client.mirror.vpm121.stderr:HTTP request sent, awaiting response... 200 OK
2016-06-11T09:18:53.826 INFO:tasks.workunit.cluster1.client.mirror.vpm121.stderr:Length: unspecified [text/x-sh]
2016-06-11T09:18:53.826 INFO:tasks.workunit.cluster1.client.mirror.vpm121.stderr:Saving to: Б
2016-06-11T09:18:53.826 INFO:tasks.workunit.cluster1.client.mirror.vpm121.stderr:
2016-06-11T09:18:53.832 INFO:tasks.workunit.cluster1.client.mirror.vpm121.stderr: 0K .......... ...... 13.5M=0.001s
2016-06-11T09:18:53.833 INFO:tasks.workunit.cluster1.client.mirror.vpm121.stderr:
2016-06-11T09:18:53.833 INFO:tasks.workunit.cluster1.client.mirror.vpm121.stderr:2016-06-11 16:18:53 (13.5 MB/s) - Б saved [16493]
2016-06-11T09:18:53.833 INFO:tasks.workunit.cluster1.client.mirror.vpm121.stderr:
2016-06-11T09:18:53.833 INFO:tasks.workunit.cluster1.client.mirror.vpm121.stderr:/home/ubuntu/cephtest/workunit.cluster1.client.mirror/rbd/rbd_mirror.sh: 12: .: rbd_mirror_helpers.sh: not found
I can't understand why though -- the script is successfully downloaded, and I failed to reproduce locally.
There was a problem hiding this comment.
@dillaman It looks I found the issue. . looks for the script in $PATH (I failed to reproduce it initially because had current dir in path). I think replacing this to
. ./rbd_mirror_helpers.sh
should fix
There was a problem hiding this comment.
@trociny Thanks for that -- I saw that it caused failures in my jewel testing branch. I am rebuilding w/o the improved tests for now so that I can re-run the failures.
rbd-mirror stress test cases need a way to disable lockdep when initiated in a vstart environment. Signed-off-by: Jason Dillaman <dillaman@redhat.com> (cherry picked from commit d5eec7b)
Fixes: http://tracker.ceph.com/issues/16197 Signed-off-by: Jason Dillaman <dillaman@redhat.com> (cherry picked from commit db3e583)
otherwise it looks in $PATH for the script Signed-off-by: Mykola Golub <mgolub@mirantis.com> (cherry picked from commit 698242e)
ghost
self-assigned this
|
It passed the rbd suite http://tracker.ceph.com/issues/16344#note-5 (except for a valgrind issue which I believe is unrelated) |
ghost
merged commit
ghost
changed the title
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tracker.ceph.com/issues/16232