jewel: msgr: backports of all asyncmsgr fixes to jewel #9633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Haomai Wang <haomai@xsky.com> (cherry picked from commit a9ac1c4)
Signed-off-by: Haomai Wang <haomai@xsky.com> (cherry picked from commit 5c0a689)
Maybe we need to add the statistics for external_events. Signed-off-by: Yan Jun <yan.jun8@zte.com.cn> (cherry picked from commit f08ca0a)
Signed-off-by: Yan Jun <yan.jun8@zte.com.cn> (cherry picked from commit 69a587b)
Signed-off-by: Yan Jun <yan.jun8@zte.com.cn> (cherry picked from commit 0519f93)
reduce cpu utilization on real clock latency Signed-off-by: Haomai Wang <haomai@xsky.com> (cherry picked from commit 79343a8)
Delay injection was missing from a few spots, also, DelayedDelivery was added. Fixes: http://tracker.ceph.com/issues/15372 Signed-off-by: Piotr Dałek <piotr.dalek@ts.fujitsu.com> (cherry picked from commit 49a0c99)
Fixes: http://tracker.ceph.com/issues/15503 Signed-off-by: Haomai Wang <haomai@xsky.com> (cherry picked from commit 83f7db5)
Signed-off-by: Haomai Wang <haomai@xsky.com> (cherry picked from commit 0a23929)
Signed-off-by: Haomai Wang <haomai@xsky.com> (cherry picked from commit 1ddeede)
This changeset makes AsyncMessenger a bit smarter when it comes to assigning worker threads to AsyncConnections. Each time a worker is assigned, its reference count is increased. Next time when Async Messenger needs to assign another worker to new AsyncConnection, it picks the one with the lowest reference count. If it cannot find an idle one, and number of currently instantiated workers is less than specified with "ms async op max threads", the new worker is created and returned. Once AsyncConnection goes away, the reference count on assigned worker is decreased. This does not prevent, but greatly reduces chances of having a single async worker thread doing most (or even all) of the ops, and also removes the need to manually tune the "ms async op threads" option. Signed-off-by: Piotr Dałek <git@predictor.org.pl> (cherry picked from commit 3e80f8d)
|
Cool, except these commits. I have created the corresponding tracker issue regard to other async pr needed to backport. |
|
@yuyuyu101 does this backport look good to merge ? It passed the rados suite http://tracker.ceph.com/issues/16344#note-7 except for one failure which I believe is unrelated). |
|
lgtm |
ghost
merged commit 
ghost
changed the title
theanalyst
changed the title
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tracker.ceph.com/issues/16487
this is the tracker for only one of the commits. the others do not have matching tracker issues.