ceph-disk: change ownership of initfile to ceph:ceph #9688
Conversation
tchaikov
changed the title
|
@shylesh could you add a line right before your and could you prefix the title of your commit message with the subcomponent your are changing ? see https://github.com/ceph/ceph/blob/master/SubmittingPatches.rst#preparing-and-sending-patches. in this case, it would be "ceph-disk: ". |
|
Done, Thanks for the input kefu |
| LOG.debug('Marking with init system %s', init) | ||
| init_path = os.path.join(path, init) | ||
| with file(init_path, 'w'): | ||
| path_set_context(init_path) |
There was a problem hiding this comment.
it should be indented to the right so that it is included in the if instead of being outside. Otherwise looks good and ready for tests ;-)
|
Sorry , some problem with vim tabs. Done |
|
could you remove "-Tracker 16280-" from the title of your commit message? and it should be good. |
|
Done |
tchaikov
changed the title
|
lgtm. |
|
@shylesh could you add this back and keep the title of the commit message unchanged? |
|
@tchaikov , |
|
the rocksdb submodule was updated by accident |
|
@dachary , Done |
|
tested in http://pulpito.ceph.com/kchai-2016-07-10_07:48:29-rados-wip-kefu-testing---basic-mira/ the non-environmental failures are addressed by #10234 . |
|
@dachary is this PR good to merge? |
|
lgtm. |
|
it looks good, just needs to fix the tox errors |
|
retest this please |
|
Let me know what tests needs to be run. Thanks, |
| @@ -3245,8 +3245,9 @@ def activate( | |||
| init = init_get() | |||
|
|
|||
| LOG.debug('Marking with init system %s', init) | |||
| with file(os.path.join(path, init), 'w'): | |||
| pass | |||
| init_path = os.path.join(path,init) | |||
There was a problem hiding this comment.
please add a space after ","
|
sorry, "retest this please" is the command to trigger the build job on jenkins. and btw, you might want to run "run-tox-ceph-disk" locally to fix the failure, see https://jenkins.ceph.com/job/ceph-pull-requests/9898/consoleFull#231334942c19247c4-fcb7-4c61-9a5d-7e2b9731c678 |
Fixes: http://tracker.ceph.com/issues/16280 Signed-off-by: Shylesh Kumar <shmohan@redhat.com>
|
@tchaikov , |
|
lgtm @dachary what do you think? |
ghost
merged commit
|
@dachary no worries =) |
Signed-off-by: shylesh kumar shylesh.mohan@gmail.com