cephx: Fix multiple segfaults due to attempts to encrypt or decrypt #9703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
*** Deleting file `test/cephtool-test-mds.sh.log' That looks like the mds test hang, known issue. |
| @@ -46,6 +46,12 @@ int CephxClientHandler::build_request(bufferlist& bl) const | |||
| return -ENOENT; | |||
| } | |||
|
|
|||
| // is the key OK? | |||
There was a problem hiding this comment.
could you add a space after if?
|
and might want to use |
badone
force-pushed
the
wip-cryptoKey-encrypt-segfault
branch
2 times, most recently
from
0263b36
to
b25d697
Compare
an empty secret and a null CryptoKeyHandler Fixes: http://tracker.ceph.com/issues/16266 Signed-off-by: Brad Hubbard <bhubbard@redhat.com>
badone
force-pushed
the
wip-cryptoKey-encrypt-segfault
branch
from
b25d697
to
009e777
Compare
|
retest this please. |
|
lgtm. |
|
retest this please |
|
tested in http://pulpito.ceph.com/kchai-2016-07-10_07:48:29-rados-wip-kefu-testing---basic-mira/ the non-environmental failures are addressed by #10234 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
an empty secret and a null CryptoKeyHandler
http://tracker.ceph.com/issues/16266
Fixes: #16266
Signed-off-by: Brad Hubbard bhubbard@redhat.com