rbd: cleanup - Proxied operations shouldn't result in error messages if replayed #9724
Conversation
|
@vumrao We don't want to suppress all errors. We only want to suppress the errors that we know will occur if you execute the operation twice. For example, creating a snapshot twice will result in -EEXISTS, deleting a snapshot twice will result in -ENOENT, etc. You can look in |
|
Thanks @dillaman ahh sorry I misunderstood it. Sure I will make changes and will send a new patch set. |
vumrao
force-pushed
the
wip-vumrao-16130
branch
2 times, most recently
from
c0977ce
to
c50efb4
Compare
| @@ -100,8 +103,11 @@ int RenameRequest<I>::filter_state_return_code(int r) { | |||
|
|
|||
| if (m_state == STATE_REMOVE_SOURCE_HEADER && r < 0) { | |||
| if (r != -ENOENT) { | |||
| lderr(cct) << "warning: couldn't remove old source object (" | |||
| << m_source_oid << ")" << dendl; | |||
| if (r == -EEXIST) | |||
There was a problem hiding this comment.
Minor: unneeded since you won't receive -EEXISTS when removing an object.
|
@dillaman thank you, sent a new patch after adding all your inputs. |
in error messages if replayed Fixes: http://tracker.ceph.com/issues/16130 Signed-off-by: Vikhyat Umrao <vumrao@redhat.com>
|
Thank you Jason! |
rbd: cleanup - Proxied operations shouldn't result
in error messages if replayed
Fixes: http://tracker.ceph.com/issues/16130
Signed-off-by: Vikhyat Umrao vumrao@redhat.com