common/WorkQueue: add std move #9729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| cct(pcct_), | ||
| name(std::move(nm)), | ||
| thread_name(std::move(tn)), | ||
| lockname(nm + "::lock"), |
There was a problem hiding this comment.
the string has been moved out of nm at this point, use name instead
There was a problem hiding this comment.
@cbodley
well spotted!
stiopaa1
force-pushed
the
common_workqueue_addMove
branch
from
0392cea
to
4ab3f4e
Compare
stiopaa1
force-pushed
the
common_workqueue_addMove
branch
from
4ab3f4e
to
fda3604
Compare
Signed-off-by: Michal Jarzabek <stiopa@gmail.com>
stiopaa1
force-pushed
the
common_workqueue_addMove
branch
from
fda3604
to
0749715
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Michal Jarzabek stiopa@gmail.com