Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hammer: build/ops: boost uuid makes valgrind complain #9741

Merged
merged 2 commits into from Aug 11, 2016

Commits on Jun 16, 2016

  1. moved to use boost uuid implementation, based on commit 4fe89a7

    Signed-off-by: Rohan Mars <code@rohanmars.com>
    Reviewed-by: Casey Bodley <cbodley@redhat.com>
    (cherry picked from commit 62bfc7a)
    
    Conflicts:
    	debian/control (trivial resolution)
    	src/common/Makefile.am (trivial resolution)
    	src/common/blkdev.cc (no get_device_by_uuid() function in hammer)
    rohanmars authored and smithfarm committed Jun 16, 2016
    Copy the full SHA
    174de7f View commit details
    Browse the repository at this point in the history
  2. uuid: use boost::random:random_device

    The boost mt code uses uninitialized memory for extra randomness,
    which is a bad idea in general but more importantly makes valgrind
    unhappy.  Use /dev/urandom instead.
    
    Unfortunately this introduces a link time dependency.. meh!
    
    Fixes: ceph#12736
    Signed-off-by: Sage Weil <sage@redhat.com>
    (cherry picked from commit dbcaa54)
    
    Conflicts:
    	ceph.spec.in (trivial resolution)
    liewegas authored and smithfarm committed Jun 16, 2016
    Copy the full SHA
    187d308 View commit details
    Browse the repository at this point in the history