rpm: fix shared library devel package names and dependencies #9744

smithfarm · 2016-06-16T08:57:20Z

Fixes: http://tracker.ceph.com/issues/16345
Fixes: http://tracker.ceph.com/issues/16346

tserong · 2016-06-16T10:26:12Z

ceph.spec.in

@@ -410,14 +413,15 @@ Striping interface built on top of the rados library, allowing
 to stripe bigger objects onto several standard rados objects using
 an interface very similar to the rados one.

-%package -n libradosstriper1-devel
+%package -n libradosstriper-devel
 Summary:	RADOS striping interface headers
 Group:		Development/Libraries
 License:	LGPL-2.0
 Requires:	libradosstriper1 = %{epoch}:%{version}-%{release}
 Requires:	librados2-devel = %{epoch}:%{version}-%{release}


Should be Requires: librados-devel

tserong · 2016-06-16T10:32:06Z

In addition to those two line notes, I did a quick search through the spec file, and I think the librbd-devel and devel-compat packages still also have Requires: lib$FOO$VERSION-devel lines, which should become Requires: lib$FOO-devel to match the renamed devel packages.

smithfarm · 2016-06-16T14:24:19Z

Thanks, @tserong, for the review. I have made the necessary corrections.

@ktdreyer @b-ranto Your thoughts on this PR?

smithfarm · 2016-06-16T14:27:41Z

I'm trying to get the latest jewel into openSUSE "Tumbleweed". This appears to be the last obstacle...

ktdreyer · 2016-06-16T14:48:00Z

I'm ok with this. We could drop the devel-compat package altogether at this point. It's quite old and everyone should upgrade through Firefly -> Hammer -> etc to pick up the newer names.

smithfarm · 2016-06-16T16:51:22Z

@ktdreyer Done. Just devel-compat? Not any of the other "compats"?

ktdreyer · 2016-06-16T16:54:57Z

I think the other -compats could go as well, but that could be a separate PR :)

ktdreyer · 2016-06-16T16:55:13Z

Reviewed-by: Ken Dreyer <kdreyer@redhat.com>

smithfarm · 2016-06-16T20:00:47Z

pushed wip-16345 to gitbuilders

smithfarm · 2016-06-17T07:51:47Z

gitbuilder likes it

smithfarm · 2016-06-17T15:10:58Z

Changelog:

rebase
add 0d9506a which ensures the old-named packages are provided and obsoleted - as per https://en.opensuse.org/openSUSE:Package_dependencies#Renaming_a_package

b-ranto · 2016-06-21T10:59:55Z

This lgtm, I'd like to see this go through some upgrade path tests though.

b-ranto · 2016-06-21T11:23:49Z

Also, when I think about it, this could probably break a lot of (qa) tooling. How would ceph-deploy/ansible handle this (especially things like purge/uninstall)?

ktdreyer · 2016-06-21T13:22:48Z

I checked ceph-deploy and ceph-ansible, and they don't bother installing any -devel RPMs.

smithfarm · 2016-06-23T14:31:11Z

Well, I've tried but these cleanups do not pass upgrade/hammer-x because it does

sudo yum -y install libcephfs_jni1 rbd-fuse ceph-radosgw librbd1 ceph-fuse python-ceph ceph ceph-devel ceph-test librados2 cephfs-java libcephfs1

(notice the presence of ceph-devel) and it fails due to a bunch of unsatisfied dependencies like this (I show only the first two here - there are many more):

Error: Package: 1:ceph-devel-compat-0.80.7-0.8.el7.x86_64 (epel)
           Requires: libcephfs_jni1-devel = 1:0.80.7
           Installing: 1:libcephfs_jni-devel-10.2.0-2477.gea64db4.el7.x86_64 (Ceph)
               libcephfs_jni1-devel = 1:10.2.0-2477.gea64db4.el7
           Available: 1:libcephfs_jni1-devel-0.80.7-0.8.el7.x86_64 (epel)
               libcephfs_jni1-devel = 1:0.80.7-0.8.el7
Error: Package: 1:python-ceph-compat-0.80.7-0.8.el7.x86_64 (epel)
           Requires: python-cephfs = 1:0.80.7
           Installing: 1:python-cephfs-10.2.0-2477.gea64db4.el7.x86_64 (Ceph)
               python-cephfs = 1:10.2.0-2477.gea64db4.el7

Next I will try upgrade/infernalis-x and upgrade/jewel-x.

ktdreyer · 2016-06-23T14:51:32Z

At this point, since Firefly is EOL, that test should probably be changed to use the -devel names from Hammer

There are no "-dev" packages listed in the deb section of this file, so it serves no purpose to have ceph-devel here. Also, once ceph/ceph#9744 is merged the presence of "ceph-devel" in this file will break teuthology for rpm targets. Signed-off-by: Nathan Cutler <ncutler@suse.com>

There are no "-dev" packages listed in the deb section of this file, so it serves no purpose to have ceph-devel here. Also, once ceph/ceph#9744 is merged the presence of "ceph-devel" in this file will break teuthology for rpm targets. Signed-off-by: Nathan Cutler <ncutler@suse.com> (cherry picked from commit af9e057)

smithfarm · 2016-06-29T23:32:46Z

JFYI ceph-devel has been dropped from the list of packages that get installed by teuthology - see ceph/ceph-qa-suite#1068

smithfarm · 2016-07-13T19:54:34Z

Rebased again.

smithfarm · 2016-07-13T19:55:22Z

Repushed wip-16345 to gitbuilders.

smithfarm · 2016-07-20T09:05:55Z

This passed gitbuilder but there's no point in running any more tests until ceph/teuthology#912 is merged.

smithfarm · 2016-07-20T10:07:06Z

Hey Jenkins, test this please (logs are gone)

Fixes: http://tracker.ceph.com/issues/16345 Signed-off-by: Nathan Cutler <ncutler@suse.com>

Fixes: http://tracker.ceph.com/issues/16346 Signed-off-by: Nathan Cutler <ncutler@suse.com>

Everyone should upgrade through Firefly -> Hammer -> etc to pick up the newer package names. Signed-off-by: Ken Dreyer <kdreyer@redhat.com> Signed-off-by: Nathan Cutler <ncutler@suse.com>

This patch ensures that packages with the new name properly replace old-named packages on upgrades. Signed-off-by: Nathan Cutler <ncutler@suse.com>

smithfarm · 2016-08-03T11:09:15Z

rebased, pushed to gitbuilder

smithfarm · 2016-08-08T09:52:16Z

fail http://pulpito.ceph.com/smithfarm-2016-08-08_02:50:55-upgrade:jewel-x-wip-16345---basic-smithi/

"RuntimeError: Fuse mount failed to populate /sys/ after 31 seconds"

smithfarm · 2016-08-08T14:35:09Z

fail http://pulpito.ceph.com/smithfarm-2016-08-08_05:24:13-upgrade:jewel-x:point-to-point-x-wip-16345---basic-smithi/

Unrelated failure due to bug http://tracker.ceph.com/issues/16529 present in the jewel branch. ~~The actual upgrade goes fine.~~ Sorry, the test (1) installs 10.2.0, (2) upgrades to latest jewel, and (3) upgrades to "x". But the test failed before it got to (3).

2016-08-08T07:20:06.916 INFO:tasks.workunit.client.1.smithi015.stdout:test/cls_rbd/test_cls_rbd.cc:1384: Failure
2016-08-08T07:20:06.916 INFO:tasks.workunit.client.1.smithi015.stdout:Value of: mirror_image_set(&ioctx, "image_id2", image2)
2016-08-08T07:20:06.916 INFO:tasks.workunit.client.1.smithi015.stdout:  Actual: -2
2016-08-08T07:20:06.917 INFO:tasks.workunit.client.1.smithi015.stdout:Expected: 0
2016-08-08T07:20:06.998 INFO:tasks.workunit.client.1.smithi015.stdout:[  FAILED  ] TestClsRbd.mirror_image (5 ms)

smithfarm · 2016-08-08T15:39:24Z

The jewel-x upgrade suite is in sorry shape.

smithfarm · 2016-08-08T16:13:28Z

pass http://pulpito.ceph.com/smithfarm-2016-08-08_07:44:47-upgrade:jewel-x-wip-16345---basic-smithi/

Chose one that currently succeeds in the nightlies.

smithfarm · 2016-08-08T19:39:29Z

@ktdreyer @b-ranto The upgrade/jewel-x job passed. OK to merge?

ktdreyer · 2016-08-08T19:44:37Z

👍 thanks

b-ranto · 2016-08-09T08:50:07Z

👍

smithfarm added bug-fix build/ops labels Jun 16, 2016

tserong reviewed Jun 16, 2016
View reviewed changes

smithfarm force-pushed the wip-16345 branch from 57300a9 to 7732221 Compare June 16, 2016 14:10

smithfarm mentioned this pull request Jun 17, 2016

rpm: drop obsolete libs-compat metapackage #9757

Merged

smithfarm force-pushed the wip-16345 branch from c509ac2 to c543e1c Compare June 17, 2016 15:02

b-ranto added the needs-qa label Jun 21, 2016

smithfarm mentioned this pull request Jun 29, 2016

packages.yaml: drop ceph-devel ceph/ceph-qa-suite#1068

Merged

smithfarm mentioned this pull request Jun 29, 2016

jewel: packages.yaml: drop ceph-devel ceph/ceph-qa-suite#1070

Merged

smithfarm force-pushed the wip-16345 branch from 0d9506a to f8be858 Compare July 13, 2016 19:54

smithfarm added 4 commits August 3, 2016 12:30

rpm: remove major version from shared library devel pkg names

bd8b518

Fixes: http://tracker.ceph.com/issues/16345 Signed-off-by: Nathan Cutler <ncutler@suse.com>

rpm: align librgw-devel dependencies with debian packaging

51cbbfe

Fixes: http://tracker.ceph.com/issues/16346 Signed-off-by: Nathan Cutler <ncutler@suse.com>

rpm: drop obsolete devel-compat meta package

33b67ee

Everyone should upgrade through Firefly -> Hammer -> etc to pick up the newer package names. Signed-off-by: Ken Dreyer <kdreyer@redhat.com> Signed-off-by: Nathan Cutler <ncutler@suse.com>

rpm: provide -devel library packages that are being obsoleted

64b03dc

This patch ensures that packages with the new name properly replace old-named packages on upgrades. Signed-off-by: Nathan Cutler <ncutler@suse.com>

smithfarm force-pushed the wip-16345 branch from f8be858 to 64b03dc Compare August 3, 2016 10:31

smithfarm merged commit 1ab7792 into ceph:master Aug 9, 2016

smithfarm deleted the wip-16345 branch August 9, 2016 09:18

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

rpm: fix shared library devel package names and dependencies #9744

rpm: fix shared library devel package names and dependencies #9744

smithfarm commented Jun 16, 2016

tserong Jun 16, 2016

smithfarm Jun 16, 2016

tserong commented Jun 16, 2016

smithfarm commented Jun 16, 2016

smithfarm commented Jun 16, 2016

ktdreyer commented Jun 16, 2016

smithfarm commented Jun 16, 2016

ktdreyer commented Jun 16, 2016

ktdreyer commented Jun 16, 2016

smithfarm commented Jun 16, 2016

smithfarm commented Jun 17, 2016

smithfarm commented Jun 17, 2016 •

edited

b-ranto commented Jun 21, 2016

b-ranto commented Jun 21, 2016 •

edited

ktdreyer commented Jun 21, 2016

smithfarm commented Jun 23, 2016 •

edited

ktdreyer commented Jun 23, 2016

smithfarm commented Jun 29, 2016

smithfarm commented Jul 13, 2016

smithfarm commented Jul 13, 2016

smithfarm commented Jul 20, 2016

smithfarm commented Jul 20, 2016

smithfarm commented Aug 3, 2016

smithfarm commented Aug 8, 2016 •

edited

smithfarm commented Aug 8, 2016 •

edited

smithfarm commented Aug 8, 2016

smithfarm commented Aug 8, 2016 •

edited

smithfarm commented Aug 8, 2016

ktdreyer commented Aug 8, 2016

b-ranto commented Aug 9, 2016

rpm: fix shared library devel package names and dependencies #9744

rpm: fix shared library devel package names and dependencies #9744

Conversation

smithfarm commented Jun 16, 2016

tserong Jun 16, 2016

Choose a reason for hiding this comment

smithfarm Jun 16, 2016

Choose a reason for hiding this comment

tserong commented Jun 16, 2016

smithfarm commented Jun 16, 2016

smithfarm commented Jun 16, 2016

ktdreyer commented Jun 16, 2016

smithfarm commented Jun 16, 2016

ktdreyer commented Jun 16, 2016

ktdreyer commented Jun 16, 2016

smithfarm commented Jun 16, 2016

smithfarm commented Jun 17, 2016

smithfarm commented Jun 17, 2016 • edited

b-ranto commented Jun 21, 2016

b-ranto commented Jun 21, 2016 • edited

ktdreyer commented Jun 21, 2016

smithfarm commented Jun 23, 2016 • edited

ktdreyer commented Jun 23, 2016

smithfarm commented Jun 29, 2016

smithfarm commented Jul 13, 2016

smithfarm commented Jul 13, 2016

smithfarm commented Jul 20, 2016

smithfarm commented Jul 20, 2016

smithfarm commented Aug 3, 2016

smithfarm commented Aug 8, 2016 • edited

smithfarm commented Aug 8, 2016 • edited

smithfarm commented Aug 8, 2016

smithfarm commented Aug 8, 2016 • edited

smithfarm commented Aug 8, 2016

ktdreyer commented Aug 8, 2016

b-ranto commented Aug 9, 2016

smithfarm commented Jun 17, 2016 •

edited

b-ranto commented Jun 21, 2016 •

edited

smithfarm commented Jun 23, 2016 •

edited

smithfarm commented Aug 8, 2016 •

edited

smithfarm commented Aug 8, 2016 •

edited

smithfarm commented Aug 8, 2016 •

edited