safe_io: Improve portability by replacing loff_t type usage with off_t. #9767
Conversation
64-bit behavior on glibc is enforced with __USE_FILE_OFFSET64 compiler error. Signed-off-by: John Coyle <dx9err@gmail.com>
| @@ -119,7 +119,7 @@ ssize_t safe_pwrite(int fd, const void *buf, size_t count, off_t offset) | |||
| } | |||
|
|
|||
| #ifdef CEPH_HAVE_SPLICE | |||
| ssize_t safe_splice(int fd_in, loff_t *off_in, int fd_out, loff_t *off_out, | |||
| ssize_t safe_splice(int fd_in, off_t *off_in, int fd_out, off_t *off_out, | |||
There was a problem hiding this comment.
loff_t is a linux specific type. and is used by underlying splice(2) system call. yeah, it's a 64bit type. but i don't get what you mean by
64-bit behavior on glibc is enforced with __USE_FILE_OFFSET64 compiler error.
There was a problem hiding this comment.
Ya sorry the comment is missing context here.
off_t == loff_t on glibc when _USE_FILE_OFFSET64 is defined. See #6301 (comment)
Musl libc provides linux splice() [1] with POSIX off_t [2].
There is no enforcement of _USE_FILE_OFFSET64 at this level. Maybe we should add a compiler error here similar to https://github.com/dx9/ceph/blob/1ff387047167686331825b592d4d396fc69da4fc/src/include/cephfs/libcephfs.h#L41
We want to make safe_splice() POSIX type compliant and ensure 64-bit usage on glibc.
?
[1] - https://git.musl-libc.org/cgit/musl/tree/include/fcntl.h#n165
[2] - http://pubs.opengroup.org/onlinepubs/009696699/basedefs/sys/types.h.html
dx9
changed the title
dx9
changed the title
|
@tchaikov ping |
|
@dx9 sorry for the latency, makes sense. merging. |
|
@tchaikov no worries, thanks. |
No description provided.