mds: fix Session::check_access() #9769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good to me (SessionMap is the only one using these extra params), but please add a doc comment to the make_path_string() declaration...its params have already been misused! |
It calls CInode::make_path_string(...) with the second argument is false. The second argument makes the third argument useless. For newly created inode, the path string is something like #1xxxxxxxxx. This can cause the access check to fail. Fixes: http://tracker.ceph.com/issues/16358 Signed-off-by: Yan, Zheng <zyan@redhat.com>
|
Will include on test branch |
gregsfortytwo
added a commit
that referenced
this pull request
Jun 27, 2016
gregsfortytwo
added a commit
that referenced
this pull request
Jun 28, 2016
…o greg-fs-testing #9769
|
http://pulpito.ceph.com/gregf-2016-06-27_22:02:48-fs-greg-fs-testing-627---basic-mira/ looks good, 3 lab infra timeouts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It calls CInode::make_path_string(...) with the second argument is
false. The second argument makes the third argument useless. For
newly created inode, the path string is something like #1xxxxxxxxx.
This can cause the access check to fail.
Fixes: http://tracker.ceph.com/issues/16358
Signed-off-by: Yan, Zheng zyan@redhat.com