msgr: set close on exec flag #9772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm |
| @@ -63,6 +63,11 @@ int Accepter::bind(const entity_addr_t &bind_addr, const set<int>& avoid_ports) | |||
| return -errno; | |||
| } | |||
|
|
|||
| if (set_close_on_exec(listen_sd)) { | |||
There was a problem hiding this comment.
please move this change to another commit.
tchaikov
force-pushed
the
wip-close-on-exec
branch
from
2d3a014
to
10002c8
Compare
|
@ukernel do you think if mds "respawn" is an unusual case or not? if yes, i will file a tracker ticket and backport this changeset to jewel after it gets merged. |
tchaikov
force-pushed
the
wip-close-on-exec
branch
from
10002c8
to
90069ce
Compare
tchaikov
force-pushed
the
wip-close-on-exec
branch
from
90069ce
to
516413c
Compare
mds execv() when handling the "respawn" command, to avoid fd leakage, and enormous CLOSE_WAIT connections after respawning, we need to set FD_CLOEXEC flag for the socket fds. Fixes: http://tracker.ceph.com/issues/16390 Signed-off-by: Kefu Chai <kchai@redhat.com>
mds execv() when handling the "respawn" command, to avoid fd leakage, and enormous CLOSE_WAIT connections after respawning, we need to set FD_CLOEXEC flag for the socket fds. Fixes: http://tracker.ceph.com/issues/16390 Signed-off-by: Kefu Chai <kchai@redhat.com>
tchaikov
force-pushed
the
wip-close-on-exec
branch
from
516413c
to
f019ad5
Compare
|
rebased against master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mds execv() when handling the "respawn" command, to avoid fd leakage,
and enormous CLOSE_WAIT connections after respawning, we need to set
FD_CLOEXEC flag for the socket fds.
Signed-off-by: Kefu Chai kchai@redhat.com