msg/async: connect authorizer fix + recv_buf size #9784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cool, I have poor know on auth .... Good catch. |
|
minor: ssize_t AsyncConnection::handle_connect_msg(ceph_msg_connect &connect, bufferlist &authorizer_bl, bufferlist &authorizer_reply) has local variable named "authorizer_bl", plz change any of these. |
|
@yuyuyu101 Will do. Do you agree with the MIN -> MAX change - I assume it was a typo? |
|
@idryomov yep, the change makes sense |
idryomov
force-pushed
the
wip-ms-async-fixes
branch
from
914ba5a
to
3be504f
Compare
|
@yuyuyu101 Updated. |
|
@idryomov BTW I hope you can create a tracker issue to prepare backport this.. |
|
needs rebase? |
state_buffer is 4096 bytes long, while connect authorizer can be arbitrarily big - an OSD service ticket with lots of per-pool or per-namespace caps is one example. We end up scribbling on invalid memory past the state_buffer and eventually crash. Move authorizer_bl up into connection and read directly into it. Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
…SIZE simple messenger's prefetch buffer is ms_tcp_prefetch_max_size. Don't cap it with TCP_PREFETCH_MIN_SIZE in the async messenger. Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
idryomov
force-pushed
the
wip-ms-async-fixes
branch
from
3be504f
to
ccc834d
Compare
|
Rebased. @yuyuyu101 Can we merge this? |
|
I will put this on my next testing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.