client: fix access violation #9793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you explain the reference counting a little more in the commit message? I think you're right but we do have references floating around here that are supposed to be removed. (The fact that cleanup is moving from the more usual handle_client_reply makes it a little more clear.) |
The MetaRequest is a refcounted object. On construction, it will default ref to 1.
The general process to make an MDS request will be:
MetaRequest *req = new MetaRequest(op);
// fill in something
int r = make_request(req, uid, gid, target);
return r;
As mentioned, make_request() will put the passed request before returning(and thereby
delete the request automatically).
To be more specific here, the make_request() will call "mds_requests[tid] = request->get();"
to keep the request well local tracked on entry(which raises the ref of request to 2).
And on error exit(especially for the following no reply is received case), by calling both
unregister_request(request);
put_request(request); // ours
, it will decrease the reference of the corresponding request to zero and thereby delete request.
Therefore the call to request thereafter is at risk of "access violation".
Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
xiexingguo
force-pushed
the
xxg-wip-client-mr
branch
from
00d1e27
to
5c409a5
Compare
Which is misleading. Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
gregsfortytwo
added a commit
that referenced
this pull request
Jun 27, 2016
…into greg-fs-testing #9793
gregsfortytwo
added a commit
that referenced
this pull request
Jun 28, 2016
…into greg-fs-testing #9793
|
http://pulpito.ceph.com/gregf-2016-06-27_22:02:48-fs-greg-fs-testing-627---basic-mira/ looks good, just 3 infra timeouts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The MetaRequest is a refcounted object. On construction, it will default ref to 1.
The general process to make an MDS request will be:
As mentioned, make_request() will put the passed request before returning(and thereby
delete the request automatically).
To be more specific here, the make_request() will call "mds_requests[tid] = request->get();"
to keep the request well local tracked on entry(which raises the ref of request to 2).
And on error exit(especially for the following no reply is received case), by calling both
, it will decrease the reference of the corresponding request to zero and thereby delete request.
Therefore the call to request thereafter is at risk of "access violation".
Signed-off-by: xie xingguo xie.xingguo@zte.com.cn