Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configure.ac: add _LIBS variables for boost_system and boost_iostreams #9848

Merged
merged 1 commit into from Aug 10, 2016

Conversation

dx9
Copy link
Contributor

@dx9 dx9 commented Jun 21, 2016

No description provided.

The checks were breaking downtstream checks for fallocate and others on Alpine.

Signed-off-by: John Coyle <dx9err@gmail.com>
@tchaikov
Copy link
Contributor

@dx9 have you tried to compile ceph on Alpine? as we are moving away from autotools, autotools build will not be maintained in the near future. so i am not sure if the efforts to fix the build on Alpine is worthy.

@dx9
Copy link
Contributor Author

dx9 commented Jun 28, 2016

@tchaikov yeppers. Both the autotools and cmake builds work on Alpine with the lastest batch of PRs. I used the autotools build for reference and testing. Also #9853 has a decent pass at packaging based on autotools. I wasn't sure when you guys were gonna cut over. I haven't tried the cmake testing line on Alpine yet.

I'm easy so no worries if you'd just prefer to ditch the configure.ac PRs. I'm fine with moving the packaging over to cmake.

LMK

@tchaikov
Copy link
Contributor

tchaikov commented Jun 29, 2016

we won't drop the configure.ac and Makefile*.am. and iiuc, autotools will not be updated as timely as it is after the change. the PR for autotools are still welcome.

@tchaikov
Copy link
Contributor

The checks were breaking downtstream checks for fallocate and others on Alpine.

could you elaborate a little bit how/why it breaks the checks for fallocate?

@dx9
Copy link
Contributor Author

dx9 commented Jun 29, 2016

fallocate() check would fail when it should pass. I never figured out why. Worked backwards commenting out blocks until it worked. :) Eventually realized it was the boost_iostreams and boost_system checks. Updated them to look like the other ones that worked. Also had to add them to the linking deps.

@tchaikov tchaikov self-assigned this Jun 29, 2016
@tchaikov
Copy link
Contributor

tchaikov commented Aug 1, 2016

lgtm.

@tchaikov tchaikov merged commit 0911db3 into ceph:master Aug 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants