Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rgw: add pg_ver to tombstone_cache #9851

Merged
merged 1 commit into from Jun 29, 2016

Conversation

cbodley
Copy link
Contributor

@cbodley cbodley commented Jun 21, 2016

a tombstone cache was added to remember the mtime of deleted objects for
use with the HTTP_IF_MODIFIED_SINCE header, but the comparison was still
failing because of a missing pg_ver. added pg_ver to the tombstone cache
so it can be passed with HTTP_DEST_PG_VER

a tombstone cache was added to remember the mtime of deleted objects for
use with the HTTP_IF_MODIFIED_SINCE header, but the comparison was still
failing because of a missing pg_ver. added pg_ver to the tombstone cache
so it can be passed with HTTP_DEST_PG_VER

Signed-off-by: Casey Bodley <cbodley@redhat.com>
@theanalyst
Copy link
Member

I'll run this by and see if I can see the old behaviour again

@cbodley
Copy link
Contributor Author

cbodley commented Jun 27, 2016

@yehudasa confirmed that we don't compare pg_ver unless they're from the same zone:

  bool operator<(const obj_time_weight& rhs) {
    ...
    if (zone_short_id != rhs.zone_short_id) {
      return (zone_short_id < rhs.zone_short_id);
    }
    return (pg_ver < rhs.pg_ver);
  }

@yehudasa
Copy link
Member

@cbodley perfect

@yehudasa
Copy link
Member

@theanalyst did you test this?

@theanalyst
Copy link
Member

Yeah ran this through the same script, no errors so far

@mattbenjamin
Copy link
Contributor

The main questions I have are longer-term:

  1. what allows us to rely on a memory-only cache?
  2. can the cache size limit be overrun? what happens in that case?

@mattbenjamin mattbenjamin merged commit ee7949f into ceph:master Jun 29, 2016
@cbodley cbodley deleted the wip-rgw-tombstone-pgver branch August 24, 2016 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants