udev: always populate /dev/disk/by-parttypeuuid #9885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ceph-disk activate-all walks /dev/disk/by-parttypeuuid at boot time. It is not necessary when udev fires ADD event for each partition and 95-ceph-osd.rules gets a chance to activate a ceph disk or journal. There are various reasons why udev ADD events may not be fired at boot (for instance Debian Jessi 8.5 never does it and CentOS 7.2 seems to be racy in that regard when a LVM root is being used). Populating /dev/disk/by-parttypeuuid fixes ceph-disk activate-all that would not work without it. And it guarantees disks are activated at boot time regardless of wether udev fires ADD events at the right time (or at all). The new udev file is a partial resurection of the 60-ceph-partuuid-workaround-rules that was removed by 9f77244. It is given a name that reflects its new purpose. Fixes http://tracker.ceph.com/issues/16351 Signed-off-by: Loic Dachary <loic@dachary.org>
ghost
added
|
@aderumier does this look sensible to you ? I think it does since that's what you suggested in the first place. Only now I better understand why this is the right solution. |
|
@dachary : I'll test it today or tomorrow. Look fine. |
|
@dachary : worked on my debian jessie running jewel 10.2.2-1~bpo80+1 on backports kernel 4.6.0-0.bpo.1-amd64 |
|
Sorry to be late, this is working fine for me too ! |
ghost
merged commit 
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ceph-disk activate-all walks /dev/disk/by-parttypeuuid at boot time. It
is not necessary when udev fires ADD event for each partition and
95-ceph-osd.rules gets a chance to activate a ceph disk or journal.
There are various reasons why udev ADD events may not be fired at
boot (for instance Debian Jessi 8.5 never does it and CentOS 7.2 seems
to be racy in that regard when a LVM root is being used).
Populating /dev/disk/by-parttypeuuid fixes ceph-disk activate-all that
would not work without it. And it guarantees disks are activated at boot
time regardless of wether udev fires ADD events at the right time (or at
all).
The new udev file is a partial resurection of the
60-ceph-partuuid-workaround-rules that was removed by
9f77244. It is given a name that
reflects its new purpose.
Fixes http://tracker.ceph.com/issues/16351
Signed-off-by: Loic Dachary loic@dachary.org