python-rados: extends ReadOp/WriteOp API #9944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sileht
added a commit
to sileht/pycradox
that referenced
this pull request
Jun 27, 2016
* rados_aio_write_op_operate * rados_write_op_omap_set * rados_read_op_set_flags * rados_aio_read_op_operate Upstream: ceph/ceph#9944
sileht
added a commit
to sileht/pycradox
that referenced
this pull request
Jun 27, 2016
* rados_aio_write_op_operate * rados_write_op_omap_set * rados_read_op_set_flags * rados_aio_read_op_operate Upstream: ceph/ceph#9944
sileht
added a commit
to sileht/pycradox
that referenced
this pull request
Jun 27, 2016
* rados_aio_write_op_operate * rados_write_op_omap_set * rados_read_op_set_flags * rados_aio_read_op_operate Upstream: ceph/ceph#9944
sileht
force-pushed
the
master
branch
2 times, most recently
from
acfbe38
to
35e5606
Compare
sileht
changed the title
|
Any new about merging this ? |
|
sorry, I meant to look at this a lot sooner. Will review today |
|
jenkins: retest this please |
| @requires(('to_write', bytes)) | ||
| def append(self, to_write): | ||
| """ | ||
| Write whole object, atomically replacing it. |
There was a problem hiding this comment.
accidentally used write_full description
|
looks good, just a couple minor comments. could you add a signed-off-by line to your commit messages? |
This change adds python API for the following C methods: * rados_aio_write_op_operate * rados_write_op_omap_set * rados_read_op_set_flags * rados_aio_read_op_operate Signed-off-by: Mehdi Abaakouk <sileht@redhat.com>
* rados_write_op_create * rados_write_op_append * rados_write_op_write_full * rados_write_op_write * rados_write_op_remove * rados_write_op_truncate * rados_write_op_zero Signed-off-by: Mehdi Abaakouk <sileht@redhat.com>
|
I have fixed the comments |
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change extends python-rados ReadOp/WriteOp API for the following C methods: