osd: remove dispatch queue check since we don't queue hb message to this #9947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We already make simple/async all OSDPing use fast dispatch, xio doesn't implment this. Otherwise if osd_lock is held by other threads which stuck into waiting FileStore throttler, it may cause heartbeat failure message delay a lot. We also consider to remove Messenger::get_dispatch_queue_max_age since it doesn't have users now. But it's fine to wait some periods to see. Signed-off-by: Haomai Wang <haomai@xsky.com>
liewegas
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already make simple/async all OSDPing use fast dispatch, xio doesn't
implment this.
Otherwise if osd_lock is held by other threads which stuck into waiting
FileStore throttler, it may cause heartbeat failure message delay a lot.
We also consider to remove Messenger::get_dispatch_queue_max_age since
it doesn't have users now. But it's fine to wait some periods to see.
Signed-off-by: Haomai Wang haomai@xsky.com