include/assert: clean up ceph assertion macros #9969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sage Weil <sage@redhat.com>
Abort with an error string. Signed-off-by: Sage Weil <sage@redhat.com>
Signed-off-by: Sage Weil <sage@redhat.com>
We will transition to these. Signed-off-by: Sage Weil <sage@redhat.com>
These variants we promise never to compile out based on NDEBUG. Signed-off-by: Sage Weil <sage@redhat.com>
|
test this please |
| @@ -129,6 +129,13 @@ using namespace ceph; | |||
| ? __CEPH_ASSERT_VOID_CAST (0) \ | |||
| : __ceph_assert_fail (__STRING(expr), __FILE__, __LINE__, __CEPH_ASSERT_FUNCTION)) | |||
|
|
|||
| // this variant will *never* get compiled out to NDEBUG in the future. | |||
| // (ceph_assert currently doesn't either, but in the future it might.) | |||
There was a problem hiding this comment.
I'm not very familiar with how our current asserts work with debug that lets them be disabled or not. Can we do something to make sure the tooling is set up properly right now, which guarantees ceph_assert_always really does get compiled in?
There was a problem hiding this comment.
Ours aren't conditional (yet)... It's the lack of an #ifdef NDEBUG where this comment goes that prevents it from compiling out. And/or the lack of a similar comment says "do not ever compile this out" next to the ceph_assert definition a few lines up.
|
Basically looks fine. |
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.