Pull in libcephfs2 instead of libcephfs1 #972
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...and remove both when nuking. Signed-off-by: Jeff Layton <jlayton@redhat.com>
This was referenced Oct 27, 2016
jcsp
reviewed
Oct 27, 2016
| @@ -8,7 +8,7 @@ ceph: | |||
| - ceph-test | |||
| - radosgw | |||
| - python-ceph | |||
| - libcephfs1 | |||
There was a problem hiding this comment.
I believe this package list only applies when running with an older ceph-qa-suite branch (e.g. hammer) that doesn't have its own packages.yaml, so the right thing is probably to leave the older package name here.
There was a problem hiding this comment.
Thanks, I'll reinstate it there. To be clear though, does that mean that this PR is not necessary?
ISTR that I had some trouble running tests without this change, but I could be mixed up here and the ceph-qa-suite changes were sufficient. I'll do a test run either way and see.
|
Yeah, looks like this PR isn't necessary. I think we can drop it for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Companion pull request for the ceph one here:
ceph/ceph#11647
...and the ceph-qa-suite one here:
ceph/ceph-qa-suite#1223
Mostly just ripple effects of the package rename.