test/dump-crash: check code path when dump crashes

Signed-off-by: Bhavik Sachdev <b.sachdev1904@gmail.com>
checkpoint-restore · Apr 26, 2024 · d471052 · d471052
1 parent 2c9e91c
commit d471052
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 0 deletions.
diff --git a/criu/cr-dump.c b/criu/cr-dump.c
@@ -2101,6 +2101,10 @@ static int cr_dump_finish(int ret)
 	close_image_dir();
 
 	if (ret || post_dump_ret) {
+		if (fault_injected(FI_DUMP_CRASH)) {
+			pr_info("fault: CRIU dump crashed!\n");
+			abort();
+		}
 		pr_err("Dumping FAILED.\n");
 	} else {
 		write_stats(DUMP_STATS);

diff --git a/criu/include/fault-injection.h b/criu/include/fault-injection.h
@@ -20,6 +20,7 @@ enum faults {
 	FI_CANNOT_MAP_VDSO = 133,
 	FI_CORRUPT_EXTREGS = 134,
 	FI_DONT_USE_PAGEMAP_SCAN = 135,
+	FI_DUMP_CRASH = 136,
 	FI_MAX,
 };
 

diff --git a/test/jenkins/criu-fault.sh b/test/jenkins/criu-fault.sh
@@ -39,3 +39,7 @@ fi
 ./test/zdtm.py run -t zdtm/static/fpu03 --fault 134 -f h --norst || fail
 # also check for the main thread corruption
 ./test/zdtm.py run -t zdtm/static/fpu00 --fault 134 -f h --norst || fail
+
+if ./test/zdtm.py run -t zdtm/static/vfork00 --fault 136 --report report -f h ; then
+	fail
+fi