Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable merging of chocolatey searches #14327

Merged

Commits on Apr 10, 2024

  1. Disable merging of chocolatey searches

    There was a time when the following worked:
    
    ```
    choco list -r firefox wireshark
    choco search -r firefox wireshark
    ```
    
    However, it turns out this only worked by accident, not by spec - and this has stopped working now.  It's known to not work, see chocolatey/choco#2116 .  Additionally, the other potential workarounds are also not well supported.  So instead, we tighten the caching a little to at least avoid multiple API requests for the same package, and drop back to single package at a time searches for now, since that's what upstream chocolatey demands.  Once we can fix the issue in chocolatey itself, then we can bring this feature back.
    
    (if you have just teh right server versions, which I did when I was testing, it does work - I was able to reproduce it as a regression, but it turns out what I considered "working" was, in fact, the bug and not the correct behaviour)
    
    Note that this means now you see in debug:
    ```
    [2024-04-10T00:36:54-07:00] INFO: Fetching chocolatey package list
    [2024-04-10T00:36:54-07:00] DEBUG: Choco List Command: ["search", "-r", "firefox"]
    [2024-04-10T00:36:55-07:00] DEBUG: Choco List Command: ["search", "-r", "wireshark"]
    [2024-04-10T00:36:58-07:00] INFO: chocolatey_package[wireshark, firefox] upgraded(allow_downgrade) ["wireshark"] to ["3.0.1"]
    ```
    
    which is correct per chocolatey spec, sadly.
    
    Signed-off-by: Jaymz Julian <jaymzjulian@meta.com>
    anotherjaymz committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    66138f9 View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2024

  1. Be consistent around taking about booleans in chocolatey_package

    Co-authored-by: Thomas Powell <104777878+tpowell-progress@users.noreply.github.com>
    
    Signed-off-by: Jaymz Julian <jaymzjulian@meta.com>
    jaymzjulian authored and anotherjaymz committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    1128e85 View commit details
    Browse the repository at this point in the history